Use gitignore in streaming mode as well #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR implements proper .gitignore handling in streaming mode by replacing WalkDir with WalkBuilder from the ignore crate.
- Added
WalkBuilderconfiguration insrc/lib.rsto respect.gitignorerules consistently across both streaming and file output modes - Added comprehensive end-to-end tests in
tests/test_gitignore_e2e.rsto verify ignore patterns work in both modes - Removed explicit gitignore check since
WalkBuildernow handles it internally - Set
follow_linksto false to match Git's behavior for symlinks
2 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
Owner
Author
|
@greptileai review |
Contributor
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR extends the gitignore functionality improvements with additional test coverage and error handling refinements.
- Added environment variables
NO_COLORandCIintests/test_gitignore_e2e.rsto ensure consistent non-interactive test behavior - Improved error messages in file reading operations with detailed path information
- Simplified binary file detection by removing user-defined extensions in streaming mode
- Disabled git_global and git_exclude in
WalkBuilderto only use local .gitignore files
3 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
tests/test_gitignore_e2e.rs
Outdated
| let repo = setup_temp_repo(); | ||
|
|
||
| // Create files without .gitignore | ||
| create_file(repo.path(), "binary.jpg", "ÿØÿÛ"); // JPEG magic bytes |
Contributor
There was a problem hiding this comment.
style: JPEG magic bytes are not properly encoded in the test file. Consider using actual binary data or hex encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25